Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

make the release script support non-mainline releases #909

Closed
dpw opened this issue Jun 12, 2015 · 2 comments · Fixed by #1372
Closed

make the release script support non-mainline releases #909

dpw opened this issue Jun 12, 2015 · 2 comments · Fixed by #1372
Assignees
Labels
Milestone

Comments

@dpw
Copy link
Contributor

dpw commented Jun 12, 2015

The release script contains various sanity checks for latest_release, and updates latest_release. That's great... until you want to do a non-mainline release.

It also assumes that release tags start with 'v'. That's conventional for mainline releases, but not necessarily what you want for preview releases etc.

I'm sure we all wish for preview releases to be a rarity, but if they do happen from time to time, it would be nice to use the release script for them with less brute force involved.

@dpw dpw added the chore label Jun 12, 2015
@rade
Copy link
Member

rade commented Jun 15, 2015

A related issue... make publish, which is called from the release script, always sets the 'latest' tag on the published images. That too will generally be the wrong thing to do for non-mainline releases.

@awh
Copy link
Contributor

awh commented Aug 24, 2015

We may wish to mark such releases with github-release release --pre-release...

@awh awh self-assigned this Aug 24, 2015
@rade rade closed this as completed in #1372 Sep 3, 2015
rade added a commit that referenced this issue Sep 3, 2015
Support draft and pre-releases in `bin/release`

Fixes #880. Fixes #909.
@rade rade modified the milestone: 1.1.0 Sep 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants