Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

proxy -D option doesn't do anything useful #972

Closed
rade opened this issue Jun 22, 2015 · 0 comments
Closed

proxy -D option doesn't do anything useful #972

rade opened this issue Jun 22, 2015 · 0 comments
Assignees
Milestone

Comments

@rade
Copy link
Member

rade commented Jun 22, 2015

I might be missing something here... but it seems to me that the -D proxy option, which configures how the proxy connects to Docker, doesn't do anything useful. The remote execution of the weave script with weavexec expects to talk to docker on the unix socket - it volume mounts the socket in exec_remote and when starting weave infrastructure containers.

If true, I suggest we get rid of the option from the docs (on latest_release_doc_updates, since we've had at least one user wasting hours because they misunderstood what -D was doing), and in the code.

@rade rade self-assigned this Jun 22, 2015
rade added a commit to rade/weave that referenced this issue Jun 22, 2015
It doesn't do anything useful since the weave script needs to be able
to talk to docker on the standard unix socket.

Also remove dangling reference to 'localhost', and move note about
firwalls to where it is most pertinent.

Part fix to weaveworks#972.
rade added a commit to rade/weave that referenced this issue Jun 22, 2015
It doesn't do anything useful since the weave script needs to be able
to talk to docker on the standard unix socket.

Fixes weaveworks#972.
rade added a commit to rade/weave that referenced this issue Jun 22, 2015
It doesn't do anything useful since the weave script needs to be able
to talk to docker on the standard unix socket.

Fixes weaveworks#972.
@rade rade modified the milestone: 1.1.0 Jul 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant