Code coverage for smoke tests. #1105

tomwilkie · 2015-07-09T10:45:22Z

Fixes #673

Allow non-circle people to build coverage reports.

test/140_weave_local_test.sh

 assert_raises "exec_on $HOST1 c1 $CHECK_ETHWE_UP"

-run_on $HOST1 sudo weave --local run             -ti --name=c2 $SMALL_IMAGE /bin/sh
+run_on $HOST1 sudo COVERAGE=$COVERAGE weave --local run             -ti --name=c2 $SMALL_IMAGE /bin/sh


test/config.sh

+collect_coverage() {
+    host=$1
+    rm -f cover.router.prof
+    docker_on $host cp weave:/home/weave/cover.router.prof . || true


testing/cover/cover.go

+	"golang.org/x/tools/cover"
+)
+
+func merge(p1, p2 *cover.Profile) *cover.Profile {


paulbellamy · 2015-07-10T15:08:08Z

It would be nice not to have a bunch of test gubbins littered around the weave script.

tomwilkie · 2015-07-10T15:24:26Z

@paulbellamy re:weave script, yeah I agree, but I can't think of a better way. Any ideas?

Code coverage for smoke tests.

weave

+    COVERAGE_ARGS=""
+    if [ -n "$COVERAGE" ] ; then
+        COVERAGE_ARGS="-test.coverprofile=/home/weave/cover.router.prof --"
+    fi


tomwilkie self-assigned this Jul 9, 2015

tomwilkie force-pushed the 673-smoke-test-coverage branch 2 times, most recently from cdfe204 to 5b70302 Compare July 10, 2015 14:32

tomwilkie changed the title ~~WIP Code coverage for smoke tests.~~ Code coverage for smoke tests. Jul 10, 2015

tomwilkie removed their assignment Jul 10, 2015

Code coverage for smoke tests.

00a7490

Allow non-circle people to build coverage reports.

tomwilkie force-pushed the 673-smoke-test-coverage branch from 84f566a to 00a7490 Compare July 10, 2015 14:45

rade reviewed Jul 10, 2015
View reviewed changes

test/140_weave_local_test.sh

assert_raises "exec_on $HOST1 c1 $CHECK_ETHWE_UP"

run_on $HOST1 sudo weave --local run -ti --name=c2 $SMALL_IMAGE /bin/sh

run_on $HOST1 sudo COVERAGE=$COVERAGE weave --local run -ti --name=c2 $SMALL_IMAGE /bin/sh

This comment was marked as abuse.

Sign in to view

tomwilkie assigned paulbellamy Jul 10, 2015

paulbellamy reviewed Jul 10, 2015
View reviewed changes

test/config.sh

collect_coverage() {

host=$1

rm -f cover.router.prof

docker_on $host cp weave:/home/weave/cover.router.prof . || true

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

Reduce repetition in Makefile.

bf81473

paulbellamy reviewed Jul 10, 2015
View reviewed changes

Review feedback

f5186e7

paulbellamy added a commit that referenced this pull request Jul 10, 2015

Merge pull request #1105 from weaveworks/673-smoke-test-coverage

e3212d4

Code coverage for smoke tests.

paulbellamy merged commit e3212d4 into master Jul 10, 2015

paulbellamy deleted the 673-smoke-test-coverage branch July 10, 2015 15:54

rade reviewed Jul 10, 2015
View reviewed changes

weave

COVERAGE_ARGS=""

if [ -n "$COVERAGE" ] ; then

COVERAGE_ARGS="-test.coverprofile=/home/weave/cover.router.prof --"

fi

This comment was marked as abuse.

Sign in to view

rade modified the milestones: current, 1.1.0 Jul 13, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code coverage for smoke tests. #1105

Code coverage for smoke tests. #1105

tomwilkie commented Jul 9, 2015

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

paulbellamy commented Jul 10, 2015

tomwilkie commented Jul 10, 2015

This comment was marked as abuse.

Code coverage for smoke tests. #1105

Code coverage for smoke tests. #1105

Conversation

tomwilkie commented Jul 9, 2015

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

paulbellamy commented Jul 10, 2015

tomwilkie commented Jul 10, 2015

This comment was marked as abuse.