Various improvements to unit test running #1120

tomwilkie · 2015-07-12T11:38:53Z

units.sh should exit on error.
Add race detector to unit test runner (fixes add race detector Makefile target and run that on CI #998)
Use local testing/cover/cover tool in gen_coverage_report.sh and units.sh
Use the scheduler to parallelise the unit tests.
Make test run id a string and differentiate between unit runs and integration runs in the scheduler.
Pipe circle env vars through to build container so we can detect when to use the scheduler
Add python requests to the weave build container.
Quote test names in urls, make flask handle url segments with slashes in.

test/gen_coverage_reports.sh

@@ -1,6 +1,7 @@
 #!/bin/bash

-set -ex
+set -eux


- units.sh should exit on error. - Add race detector to unit test runner. - Use local testing/cover/cover tool in gen_coverage_report.sh and units.sh - Use the scheduler to parallelise the unit tests. - Make test run id a string and differentiate between unit runs and integration runs in the scheduler. - Pipe circle env vars through to build container so we can detect when to use the scheduler - Add python requests to the weave build container. - Quote test names in urls, make flask handle url segments with slashes in.

tomwilkie · 2015-07-13T09:35:46Z

Sorry, bad merge. I've removed it now.

test/units.sh

-	if ! go test -cpu 4 -tags netgo -covermode=count -coverprofile=$output $dir ; then
-		fail=1
-	fi
+TESTDIRS=$(find . -type f -name '*_test.go' | xargs -n1 dirname | grep -v prog | sort -u)


Various improvements to unit test running

dpw · 2015-07-20T20:10:40Z

Why is the weave-build container being overloaded to run tests? If you want a container to run tests, then introduce one for that purpose. And layer it on top of a common base with weave-build, if that makes sense. But weave-build is for building weave, and only for that. Please clean this up, and copy me on PRs that touch weave-build in future.

rade reviewed Jul 12, 2015
View reviewed changes

test/gen_coverage_reports.sh

@@ -1,6 +1,7 @@

#!/bin/bash

set -ex

set -eux

This comment was marked as abuse.

Sign in to view

tomwilkie force-pushed the 998-race branch from 27e55bd to 13f1239 Compare July 13, 2015 09:33

awh self-assigned this Jul 13, 2015

awh reviewed Jul 13, 2015
View reviewed changes

test/units.sh

if ! go test -cpu 4 -tags netgo -covermode=count -coverprofile=$output $dir ; then

fail=1

fi

TESTDIRS=$(find . -type f -name '*_test.go' | xargs -n1 dirname | grep -v prog | sort -u)

This comment was marked as abuse.

Sign in to view

awh added a commit that referenced this pull request Jul 13, 2015

Merge pull request #1120 from weaveworks/998-race

d644380

Various improvements to unit test running

awh merged commit d644380 into master Jul 13, 2015

awh deleted the 998-race branch July 13, 2015 13:10

rade modified the milestones: current, 1.1.0 Jul 13, 2015

tomwilkie mentioned this pull request Jul 21, 2015

Don't run unit tests in build container #1204

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various improvements to unit test running #1120

Various improvements to unit test running #1120

tomwilkie commented Jul 12, 2015

This comment was marked as abuse.

tomwilkie commented Jul 13, 2015

This comment was marked as abuse.

dpw commented Jul 20, 2015

Various improvements to unit test running #1120

Various improvements to unit test running #1120

Conversation

tomwilkie commented Jul 12, 2015

This comment was marked as abuse.

tomwilkie commented Jul 13, 2015

This comment was marked as abuse.

dpw commented Jul 20, 2015