remove outermost gob #1189

rade · 2015-07-17T16:07:07Z

...replacing it with length-prefix encoding.

Addresses part of #519.

dpw · 2015-07-20T15:59:39Z

Looks like it might end up with two identical lines in doIntroV1 and doIntroV2.

Ah, I see - they diverge again in the later commit, so no point in unifying them.

rade · 2015-07-20T19:44:02Z

@dpw I have addressed all your feedback. Will squash the commits once you are happy.

dpw · 2015-07-20T19:47:34Z

That was all, squash away.

switch from gob to length-prefix encoding

so we do not allocate loads of memory when receiving (accidental or deliberate) garbage

rade · 2015-07-21T08:19:51Z

squash away

Done.

rade self-assigned this Jul 19, 2015

rade force-pushed the 519_remove_outermost_gob branch from 020a9a7 to c27f6d6 Compare July 20, 2015 11:23

rade assigned dpw and unassigned rade Jul 20, 2015

rade force-pushed the 519_remove_outermost_gob branch from 4294fd4 to e294eac Compare July 20, 2015 22:48

rade added 4 commits July 20, 2015 23:50

refactor: make 'inner' encoder/decoder explicit

ad4e4ce

refactor: s/SimpleTCP{Sender,Receiver}/GobTCP{Sender,Receiver}

af049ef

replace outermost framing on tcp connection

6f8622a

switch from gob to length-prefix encoding

enforce a message size limit

0b7d462

so we do not allocate loads of memory when receiving (accidental or deliberate) garbage

rade force-pushed the 519_remove_outermost_gob branch from e294eac to 0b7d462 Compare July 20, 2015 22:54

dpw merged commit 0b7d462 into master Jul 21, 2015

dpw added a commit that referenced this pull request Jul 21, 2015

Merge weaveworks/519_remove_outermost_gob (PR #1189)

26dc83d

rade deleted the 519_remove_outermost_gob branch July 21, 2015 12:14

rade added this to the 1.1.0 milestone Jul 21, 2015

Provide feedback