Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Disable dns in multiweave #1193

Merged
merged 2 commits into from
Jul 20, 2015
Merged

Disable dns in multiweave #1193

merged 2 commits into from
Jul 20, 2015

Conversation

rade
Copy link
Member

@rade rade commented Jul 19, 2015

Introduce a --no-dns option to weave launch[-router]. Undocumented, since it's mainly intended for testing. And use that in multiweave, so it works again, post #1065.

rade added 2 commits July 19, 2015 22:51
undocumented, since it is mainly meant for testing
Thus unbreaking it post #1065.
@tomwilkie
Copy link
Contributor

If I understand correctly, the only thing stopping multiweave starting is the dns port mapping? If so, why not disable that (as this change does) for multiweave, but leave all the dns gossip going? Isn't that what multiweave is suppose to be testing?

@rade
Copy link
Member Author

rade commented Jul 20, 2015

why not disable that (as this change does) for multiweave, but leave all the dns gossip going?

Didn't realise that was possible. So leave nameserver.New and just skip nameserver.NewDNSServer?

@tomwilkie
Copy link
Contributor

You could do that. Or you could launch both the servers, and just keep the
changes in the weave script to prevent the port mapping.

On Monday, 20 July 2015, Matthias Radestock [email protected]
wrote:

why not disable that (as this change does) for multiweave, but leave all
the dns gossip going?

Didn't realise that was possible. So leave nameserver.New and just skip
nameserver.NewDNSServer?


Reply to this email directly or view it on GitHub
#1193 (comment).

@rade
Copy link
Member Author

rade commented Jul 20, 2015

You could do that. Or you could launch both the servers, and just keep the changes in the weave script to prevent the port mapping.

Right. That's a tad obscure if anybody ever does use this option outside testing, since weave status would happily report weavedns as running.

@rade
Copy link
Member Author

rade commented Jul 20, 2015

Thinking about it more, I'd rather leave it as is. Disabling DNS should disable all of it. That's the only sensible choice if the option is to be at all useful outside the confines of multiweave.

@tomwilkie
Copy link
Contributor

The test failure is #1158

@@ -80,6 +81,7 @@ func main() {
mflag.StringVar(&ipsubnetCIDR, []string{"#ipsubnet", "#-ipsubnet", "-ipalloc-default-subnet"}, "", "subnet to allocate within by default, in CIDR notation")
mflag.IntVar(&peerCount, []string{"#initpeercount", "#-initpeercount", "-init-peer-count"}, 0, "number of peers in network (for IP address allocation)")
mflag.StringVar(&apiPath, []string{"#api", "-api"}, "unix:///var/run/docker.sock", "Path to Docker API socket")
mflag.BoolVar(&noDNS, []string{"-no-dns"}, false, "disable DNS server")

This comment was marked as abuse.

This comment was marked as abuse.

tomwilkie added a commit that referenced this pull request Jul 20, 2015
@tomwilkie tomwilkie merged commit 4e56247 into master Jul 20, 2015
@tomwilkie tomwilkie deleted the disable_dns_in_multiweave branch July 20, 2015 09:41
@rade rade added this to the 1.1.0 milestone Jul 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants