-
Notifications
You must be signed in to change notification settings - Fork 670
Conversation
undocumented, since it is mainly meant for testing
Thus unbreaking it post #1065.
If I understand correctly, the only thing stopping multiweave starting is the dns port mapping? If so, why not disable that (as this change does) for multiweave, but leave all the dns gossip going? Isn't that what multiweave is suppose to be testing? |
Didn't realise that was possible. So leave |
You could do that. Or you could launch both the servers, and just keep the On Monday, 20 July 2015, Matthias Radestock [email protected]
|
Right. That's a tad obscure if anybody ever does use this option outside testing, since |
Thinking about it more, I'd rather leave it as is. Disabling DNS should disable all of it. That's the only sensible choice if the option is to be at all useful outside the confines of multiweave. |
The test failure is #1158 |
@@ -80,6 +81,7 @@ func main() { | |||
mflag.StringVar(&ipsubnetCIDR, []string{"#ipsubnet", "#-ipsubnet", "-ipalloc-default-subnet"}, "", "subnet to allocate within by default, in CIDR notation") | |||
mflag.IntVar(&peerCount, []string{"#initpeercount", "#-initpeercount", "-init-peer-count"}, 0, "number of peers in network (for IP address allocation)") | |||
mflag.StringVar(&apiPath, []string{"#api", "-api"}, "unix:///var/run/docker.sock", "Path to Docker API socket") | |||
mflag.BoolVar(&noDNS, []string{"-no-dns"}, false, "disable DNS server") |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Introduce a
--no-dns
option toweave launch[-router]
. Undocumented, since it's mainly intended for testing. And use that in multiweave, so it works again, post #1065.