This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
add a sleep to improve test reliability #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
added a commit
that referenced
this pull request
Aug 10, 2015
add a sleep to improve test reliability
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1243.
I've also raised #1267 to address the issue more directly. The reason this is cropping up in this test more than others is that here we only start one container between launching weave and 'ping'ing, whereas elsewhere we start two. The extra start adds just enough of a delay for the routers to establish connectivity. So does a 'sleep', which is how I've "fixed" it - I've had 10 successful runs on CircleCI like that, only interrupted by some unrelated failures.