Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Move ListVar into common, so it can be reused elsewhere. #1289

Merged
merged 1 commit into from
Aug 12, 2015

Conversation

tomwilkie
Copy link
Contributor

No description provided.

@dpw
Copy link
Contributor

dpw commented Aug 12, 2015

Can we put this in a specific package please, not common. If common is to have any valid rationale at all, it should be reserved for things which are genuinely an extremely common requirement. This does not seem to fit that criterion.

I know that common is already down the slippery slope towards being a dumping ground for stuff that did not seem to fit anywhere else. But the first step to addressing that is to stop making the problem worse. And the problem of common is compounded by the fact that it is dot imported by various files.

@tomwilkie
Copy link
Contributor Author

Fair enough - any suggestions? common/listvar? common/flags?

@dpw
Copy link
Contributor

dpw commented Aug 12, 2015

Fair enough - any suggestions? common/listvar? common/flags?

It looks like it is specific to the mflag package. Calling it just common/mflag would lead to an annoying clash. So common/mflagext or similar.

@tomwilkie
Copy link
Contributor Author

@dpw PTAL

@dpw
Copy link
Contributor

dpw commented Aug 12, 2015

@dpw PTAL

Fine by me.

tomwilkie added a commit that referenced this pull request Aug 12, 2015
Move ListVar into common, so it can be reused elsewhere.
@tomwilkie tomwilkie merged commit cdab6a7 into master Aug 12, 2015
@tomwilkie tomwilkie deleted the move-listvar branch August 12, 2015 11:56
@rade rade added this to the 1.1.0 milestone Aug 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants