This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
clarify test 160 #1331
Merged
clarify test 160 #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| weave_on $HOST2 launch-router | ||
| # Introduce host3 to remember the IPAM CRDT when we stop host2 | ||
| weave_on $HOST3 launch-router $HOST2 | ||
| stop_router_on $HOST2 | ||
| weave_on $HOST1 launch-router $HOST3 | ||
| assert_raises "DOCKER_HOST=tcp://$HOST1:$DOCKER_PORT timeout 30 $WEAVE launch-router $HOST3" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
bboreham
force-pushed
the
clarify-test-160
branch
from
15e8abe
to
4d49bf3
Compare
rade
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of the last few lines of test 160 is to see whether starting weave in a state where it thinks it should talk to a currently-stopped peer will hang it. This change makes this clearer (but does not run the launch command in a
timeoutwrapper becauseweave_onis a shell function and it's too complicated to extract it out fortimeoutto call).