Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

better error handling for invalid weave status sub-command #1335

Merged
merged 1 commit into from
Aug 20, 2015

Conversation

rade
Copy link
Member

@rade rade commented Aug 20, 2015

instead of showing '404 page not found'

Fixes #1328.

@rade rade removed the in progress label Aug 20, 2015
@awh awh self-assigned this Aug 20, 2015
@awh
Copy link
Contributor

awh commented Aug 20, 2015

This is printing an unwanted newline when the sub-command output is empty:

vagrant@vagrant-ubuntu-vivid-64:~/weave$ ./weave status peers
da:67:55:44:54:81(vagrant-ubuntu-vivid-64)
vagrant@vagrant-ubuntu-vivid-64:~/weave$ ./weave status dns

vagrant@vagrant-ubuntu-vivid-64:~/weave$ ./weave status connections

vagrant@vagrant-ubuntu-vivid-64:~/weave$ ./weave status targets

vagrant@vagrant-ubuntu-vivid-64:~/weave$

@awh awh assigned rade and unassigned awh Aug 20, 2015
instead of showing '404 page not found'

Fixes #1328.
@rade rade force-pushed the 1328_handle_invalid_status_sub_command branch from 5e6690f to ceff3be Compare August 20, 2015 10:15
@rade rade removed their assignment Aug 20, 2015
@rade
Copy link
Member Author

rade commented Aug 20, 2015

This is printing an unwanted newline when the sub-command output is empty

Fixed.

@awh awh self-assigned this Aug 20, 2015
awh added a commit that referenced this pull request Aug 20, 2015
…ub_command

better error handling for invalid `weave status` sub-command
@awh awh merged commit 3803d79 into master Aug 20, 2015
@rade rade deleted the 1328_handle_invalid_status_sub_command branch August 20, 2015 16:34
@rade rade modified the milestone: 1.1.0 Aug 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants