This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Make reverse dns lookups honor tombstones. #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -121,7 +121,7 @@ func (n *Nameserver) ReverseLookup(ip address.Address) (string, error) { | |||
| defer n.RUnlock() | |||
|
|
|||
| match, err := n.entries.first(func(e *Entry) bool { | |||
| return e.Addr == ip | |||
| return e.Tombstone > 0 && e.Addr == ip | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Smoke test? |
|
Still assigned to me; was just writing the test... |
tomwilkie
force-pushed
the
1357-dns-reverse-tombstone
branch
from
97b6158
to
46363f4
Compare
|
I've confirmed without the fix the test fails. |
|
|
||
| for name in bar bar black sheep have you any wool; do | ||
| start_container $HOST1 $IP/24 --name=$name | ||
| assert "exec_on $HOST1 c1 dig +short -x $IP" $name.weave.local. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Failures are unrelated, see #1360 |
|
LGTM |
tomwilkie
added a commit
that referenced
this pull request
Aug 27, 2015
Make reverse dns lookups honor tombstones.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1357