This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Supply a --dns-search to blank the inherited resolv.conf search #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the absence of *either* a `--dns` or `--dns-search` argument, Docker will write a `/etc/resolv.conf` based on the host's. Since, in general, we rely on the DNS search path being empty (so that the resolver uses the local domain), we want to blank the `/etc/resolv.conf` by providing `--dns-search=.` when running a container. However, if there's a `--dns-search=` in the remainder of the args, Docker will append them to the dot, which breaks resolution. Not good. So, we only "blank" the search path if there's no `--dns-search` argument present already.
|
LGTM |
squaremo
added a commit
that referenced
this pull request
Nov 11, 2014
Supply a --dns-search to blank the inherited resolv.conf search (fixes #172)
marccarre
added a commit
that referenced
this pull request
Jan 6, 2017
If the machine coordinating the test runs does not have jq, then test #175 fails with: > test #1 "weave_on test-0.lon1.weave-net report | jq -r '.Router.Targets[] | tostring' | sort" failed: > expected "test-1.lon1.weave-net > test-2.lon1.weave-net" > got nothing This change completely removes the dependency on jq to make the test more robust and avoid potential confusion.
marccarre
added a commit
that referenced
this pull request
Jan 9, 2017
If the machine coordinating the test runs does not have jq, then test #175 fails with: > test #1 "weave_on test-0.lon1.weave-net report | jq -r '.Router.Targets[] | tostring' | sort" failed: > expected "test-1.lon1.weave-net > test-2.lon1.weave-net" > got nothing This change completely removes the dependency on jq to make the test more robust and avoid potential confusion.
marccarre
added a commit
that referenced
this pull request
Jan 9, 2017
If the machine coordinating the test runs does not have jq, then test #175 fails with: > test #1 "weave_on test-0.lon1.weave-net report | jq -r '.Router.Targets[] | tostring' | sort" failed: > expected "test-1.lon1.weave-net > test-2.lon1.weave-net" > got nothing This change completely removes the dependency on jq to make the test more robust and avoid potential confusion.
awh
added a commit
that referenced
this pull request
Jan 9, 2017
Removed dependency on jq in test #175.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the absence of either a
--dnsor--dns-searchargument,Docker will write a
/etc/resolv.confbased on the host's. Since, ingeneral, we rely on the DNS search path being empty (so that the
resolver uses the local domain), we want to blank the
/etc/resolv.confby providing--dns-search=.when running acontainer.
However, if there's a
--dns-search=in the remainder of the args,Docker will append them to the dot, which breaks resolution. Not good.
So, we only "blank" the search path if there's no
--dns-searchargument present already.