This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Prevent from creating multiple flows for non-real broadcasts #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When router.Macs expires and an ODP flow gets evicted, it's possible to install a "broadcast" flow for non-real broadcast packets, if container and weave FIBs contain a necessary MAC entry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents from installing ODP flows in the case of "non-real" broadcast (= relaying a non-broadcast packet to all ports when the router does not know to which port to send for a given
dst_mac).The decision about the installation is moved to
fastdp.sendfunction which is the only one that can create a flow.Fixes #2428