This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Ensure we have the right modules loaded for weave-npc #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
issues/2726-modprobe
branch
from
b87463b
to
cb73cf3
Compare
|
I have tested this by hand, by modifying the Docker daemon parameters to include |
brb
approved these changes
Feb 27, 2017
weitzj
reviewed
Mar 1, 2017
| @@ -15,6 +15,12 @@ CONN_LIMIT=${CONN_LIMIT:-30} | |||
| # Default for network policy | |||
| EXPECT_NPC=${EXPECT_NPC:-1} | |||
|
|
|||
| # Ensure we have the required modules for NPC | |||
| if [ "${EXPECT_NPC}" != "0" ]; then | |||
| modprobe br_netfilter | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2726
At least when
weave-npcis executed via theweave-kubedaemonset. It would be nicer to separate those two concerns, but we already need to know thatweave-npcis in use when creating the bridge.