Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

lazily add iptables rule to drop egress traffic from the pods only if network policies are applied #3639

Merged
merged 2 commits into from
May 7, 2019

Conversation

murali-reddy
Copy link
Contributor

does not address #3464 but just avoids the issue atleast for those who
don't use network policies

if network policies are applied

does not address #3464 but just avoids the issue atleast for those who
dont use network policies
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good - see comments below.

npc/controller.go Outdated Show resolved Hide resolved
npc/controller.go Outdated Show resolved Hide resolved
npc/controller.go Outdated Show resolved Hide resolved
@murali-reddy
Copy link
Contributor Author

Addressed review comments. PTAL

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants