Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

delete weave-daemonset.yaml #3674

Merged
merged 2 commits into from
Aug 30, 2019
Merged

delete weave-daemonset.yaml #3674

merged 2 commits into from
Aug 30, 2019

Conversation

murali-reddy
Copy link
Contributor

@murali-reddy murali-reddy commented Jul 31, 2019

delete weave-daemonset.yaml which predates the manifest weave-daemonset-k8s-1.6/1.7/1.8.yaml and was used for older versions (< 1.6).

Naming is counter intuitive to think its the latest one to be updated when ever there is change is needed in the manifests.

@bboreham
Copy link
Contributor

There are a few references to this file to clean up:

$ git grep weave-daemonset.yaml
bin/release:    sed -i.bak -e "s/:latest/:$VERSION/" -e "/imagePullPolicy: Always/d" ./prog/weave-kube/weave-daemonset.yaml
bin/release:        --name "weave-daemonset.yaml" \
bin/release:        --file "./prog/weave-kube/weave-daemonset.yaml"
bin/release:            --name "weave-daemonset.yaml" \
bin/release:            --file "./prog/weave-kube/weave-daemonset.yaml"
docs/entrypoints.md:    * set a default for the environment variable in `prog/weave-kube/weave-daemonset-k8s-1.6.yaml` and `weave-daemonset.yaml`
site/kubernetes/kube-addon.md:$ curl -fsSLo weave-daemonset.yaml "https://cloud.weave.works/k8s/net?k8s-version=$(kubectl version | base64 | tr -d '\n')"

@bboreham bboreham merged commit 1e0431f into master Aug 30, 2019
@bboreham bboreham deleted the weave-daemonset branch August 30, 2019 09:25
@bboreham bboreham added this to the 2.6 milestone Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants