This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
show IP addresses in attach/expose/detach/hide #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output contains one IP address for each addr (i.e. [ip:]<cidr> | net:<cidr> | net:default) supplied on the command line; or, if none was specified, a single address from the default IPAM subnet. We don't want `weave run` to output the addresses, since it is meant to (only) output the container id. Hence we redirect the `attach` output to stderr in that case. Closes weaveworks#954.
rade
force-pushed
the
954_show_attach_expose_addresses
branch
from
b304824
to
7cf0d59
Compare
awh
added a commit
that referenced
this pull request
Jun 22, 2015
show IP addresses in attach/expose/detach/hide
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #954.