This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Eliminate start methods #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,6 +84,9 @@ func NewRouter(config Config, name PeerName, nickName string) *Router { | |||
| return router | |||
| } | |||
|
|
|||
| // Start listening for packets from containers, TCP connections and | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
rest looks fine. |
rade
added a commit
that referenced
this pull request
Jun 24, 2015
Eliminate most Start methods in router package
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most start methods in the router are trivially redundant. Apart from the redundancy, start methods raise the question of the state of an object prior to the start method being called (i.e. which fields are valid, which methods can be called, etc.). So they should only be used when there is a reason.
(Extracted from #991)