This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Let Scope use these integration test helpers #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| WEAVE=../weave | ||
| DOCKER_NS=./bin/docker-ns | ||
| WEAVE=$DIR/../weave | ||
| DOCKER_NS=$DIR/../bin/docker-ns |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| parallel: true | ||
| - cd $SRCDIR/test; . ./gce.sh hosts; ./setup.sh: | ||
| parallel: true | ||
| - cd $SRCDIR/test; . ./gce.sh hosts; ./run_all.sh: |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Have you tested this on the weaveworks/weave? |
| - cd $SRCDIR/test; . ./gce.sh hosts; ./run_all.sh: | ||
| - ? > | ||
| if [[ -e "/tmp/gce_private_key.json" ]]; then | ||
| cd $SRCDIR/integration; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Reverted the commit with the modifications to |
|
LGTM |
paulbellamy
added a commit
that referenced
this pull request
Jun 29, 2015
Let Scope use these integration test helpers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since scope has to check out the latest weave release anyway, we may as well use the test helpers from there, and only manage them in one place.
This must be merged, and into a release before: weaveworks/scope#273