Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in GQL batch request #3431

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix panic in GQL batch request #3431

merged 1 commit into from
Aug 22, 2023

Conversation

dirkkul
Copy link
Contributor

@dirkkul dirkkul commented Aug 22, 2023

What's being changed:

Adds check for casting and return error if not possible.

Closes #3258
Fixes CVE-2023-38976

Review checklist

  • All new code is covered by tests where it is reasonable.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (0e6c9ba) 64.11% compared to head (239a81c) 64.10%.
Report is 3 commits behind head on stable/v1.21.

❗ Current head 239a81c differs from pull request most recent head 545de1b. Consider uploading reports for the commit 545de1b to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           stable/v1.21    #3431      +/-   ##
================================================
- Coverage         64.11%   64.10%   -0.01%     
================================================
  Files               757      757              
  Lines             76871    76882      +11     
================================================
+ Hits              49286    49288       +2     
- Misses            24525    24532       +7     
- Partials           3060     3062       +2     
Files Changed Coverage Δ
adapters/handlers/rest/handlers_graphql.go 0.00% <0.00%> (ø)
modules/generative-openai/config/class_settings.go 75.89% <ø> (ø)
modules/generative-palm/clients/palm.go 53.12% <ø> (-0.37%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@etiennedi etiennedi merged commit a4ea0be into stable/v1.21 Aug 22, 2023
15 of 17 checks passed
@dirkkul dirkkul deleted the fix_panic_request branch August 22, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants