Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tests to run faster #270

Closed
2 tasks
Spomky opened this issue Sep 1, 2022 · 1 comment · Fixed by #272
Closed
2 tasks

Allow tests to run faster #270

Spomky opened this issue Sep 1, 2022 · 1 comment · Fixed by #272
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Spomky
Copy link
Contributor

Spomky commented Sep 1, 2022

Version(s) affected

4.2.x

Description

Integration and functional tests are slow.
This is due to the real dataset from FIDO Alliance that is used for testing the Symfony Bundle and some other specific use cases.

How to reproduce

See CI results

Possible Solution

The tests should be modified so that:

  • The FIDO Alliance dataset is only used in a selected number of tests to verify it is loaded as expected
  • The Symfony and specific use cases should only use a MetadataStatementRepository with MDS that are really needed for each test

Additional Context

Another side effect is that mutuation tests should also run faster.

@Spomky Spomky added the enhancement New feature or request label Sep 1, 2022
@Spomky Spomky added this to the 4.2.0 milestone Sep 1, 2022
@Spomky Spomky self-assigned this Sep 1, 2022
@Spomky Spomky linked a pull request Sep 1, 2022 that will close this issue
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant