Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast tests #272

Merged
merged 8 commits into from
Sep 1, 2022
Merged

Fast tests #272

merged 8 commits into from
Sep 1, 2022

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Sep 1, 2022

No description provided.

@Spomky Spomky added the enhancement New feature or request label Sep 1, 2022
@Spomky Spomky added this to the 4.2.0 milestone Sep 1, 2022
@Spomky Spomky self-assigned this Sep 1, 2022
@gitguardian
Copy link

gitguardian bot commented Sep 1, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
206539 Generic High Entropy Secret fe73c88 tests/symfony/functional/Assertion/AssertionTest.php View secret
3901928 Generic High Entropy Secret fe73c88 tests/symfony/functional/Assertion/AssertionTest.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Spomky Spomky linked an issue Sep 1, 2022 that may be closed by this pull request
2 tasks
@Spomky Spomky changed the title Disable XDebug when not needed Fast tests Sep 1, 2022
@Spomky Spomky merged commit e597d95 into 4.2.x Sep 1, 2022
@Spomky Spomky deleted the bugs/rector-speed branch September 1, 2022 19:57
@szepeviktor
Copy link
Contributor

Xdebug is enabled by default on Ubuntu GitHub Actions images,

https://github.com/shivammathur/setup-php#signal_strength-coverage-support

Add coverage: "none"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow tests to run faster
2 participants