Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PR template #271

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Improve PR template #271

merged 1 commit into from
Sep 1, 2022

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Sep 1, 2022 •
edited
Loading

from Larastan
Please see diff!

@szepeviktor
Improve PR template
a662394 
from Larastan
@Spomky
Copy link
Contributor

Spomky commented Sep 1, 2022

This is a good idea to change it.
Do you know if it is possible to create one in YAML? The doc page is mute about that

@szepeviktor
Copy link
Contributor Author

AFAIK these templates are plain text files.
After the PR is created GitHub renders the user-edited content.

@szepeviktor
Copy link
Contributor Author

Target branch: wrench 🔧
Resolves issue #000

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Sep 1, 2022 •
edited
Loading

What you want is Issue Forms for PR-s
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms
... but there is no such a thing.

@Spomky
Copy link
Contributor

Spomky commented Sep 1, 2022

What you want is Issue Forms for PR-s

This is excatly what I was looking for, but it does not seem to be available.
Anyway, this one looks good to me

@Spomky Spomky merged commit eae194f into web-auth:4.2.x Sep 1, 2022
@szepeviktor szepeviktor deleted the patch-2 branch September 1, 2022 20:00
@Spomky Spomky added this to the 4.2.0 milestone Sep 1, 2022
@github-actions github-actions bot mentioned this pull request Sep 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @Spomky