Move event dispatching from bundle to library #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
reviewed
Oct 4, 2022
src/webauthn/src/Event/AuthenticatorAssertionResponseValidationFailedEvent.php
Show resolved
Hide resolved
amenophis
commented
Oct 4, 2022
src/symfony/src/Event/AuthenticatorAssertionResponseValidationFailedEvent.php
Outdated
Show resolved
Hide resolved
|
Another good one. Many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch:
Resolves issue #
Move Eventdispatching to library instead of bundle.
Add BC layer in the bundle and trigger depreciation.
About BC, not sur if it's OK to remove the extends
Symfony\Contracts\EventDispatcher\Event?If we don't want to handle BC, we can target the 5.x branch, and remove the BC layer.