Replace fetch by XHR and remove _dispatchEvent #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch:
Resolves issue #
window.credentials API didn't work well on iOS when used with fetch.
This PR replace fetch usages by XMLHttpRequest with Promise.
Tested on iPhone 8 with iOS 15.7, it works much better.
I also remove this._dispatchEvent because it seems useless.
@Spomky What can we add in case of error to send the error message to the user ?