Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add packages required for serialization #560

Merged

Conversation

joostdebruijn
Copy link
Contributor

Target branch: 4.8.0
Resolves issue: n/a

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

Those packages are required to make the serializer work.

@Spomky
Copy link
Contributor

Spomky commented Feb 26, 2024

Hi,

😅 I missed these dependencies.
They are also needed in MetadataStatementSerializerFactory.

@Spomky Spomky force-pushed the joost/feat-add-serializer-suggests branch from 4e94bdd to 0f8e422 Compare February 26, 2024 07:55
@Spomky Spomky added this to the 4.8.1 milestone Feb 26, 2024
@Spomky Spomky self-assigned this Feb 26, 2024
@Spomky Spomky added the dependencies Pull requests that update a dependency file label Feb 26, 2024
@Spomky Spomky merged commit 670ded8 into web-auth:4.8.x Feb 26, 2024
13 of 14 checks passed
@joostdebruijn
Copy link
Contributor Author

joostdebruijn commented Feb 26, 2024

@Spomky Thanks for merging this one! However, the web-auth/webauthn-lib sub repository doesn't have the Symfony serializer related packages now (also not in the suggest)? I'm using that sub repo for my own implementation in the Laravel-framework, however the three Symfony serializer related packages are necessary for parsing the authenticator responses for example. Shouldn't they be added as suggested package at least?

@Spomky
Copy link
Contributor

Spomky commented Feb 26, 2024

No worries, it is automatically split and tagged on release

@joostdebruijn
Copy link
Contributor Author

@Spomky Hm, I'm using v4.8.1 now and when only requiring web-auth/webauthn-lib, the symfony serializer packages must be installed separately.

@joostdebruijn
Copy link
Contributor Author

The package phpdocumentor/reflection-docblock should be added as dependency well as I discovered in production where my dev dependencies are not installed. 😅

@joostdebruijn joostdebruijn deleted the joost/feat-add-serializer-suggests branch February 26, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants