fix(web-extract): fix the extractor may fail if there is no <body/> #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yuyutaotao
commented
Aug 27, 2024
•
yuyutaotao
commented
- fix the extractor may fail if there is no
- log the dump file when locator fails
- collect div with aria attributes
✅ Deploy Preview for midscene ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zhoushaw
reviewed
Aug 28, 2024
| @@ -212,6 +213,31 @@ export function extractTextWithPosition( | |||
| return; | |||
| } | |||
|
|
|||
| if (isWidgetElement(node)) { | |||
There was a problem hiding this comment.
为什么这里是判断有没有 aria 属性就是 form 元素了
There was a problem hiding this comment.
这个是不是直接判断可见性，如果这个节点不是 input、img、text，并且是可见的有宽高的，我们就把他加到里面去，类型是 container，是不是可以减少类似的问题
There was a problem hiding this comment.
不过这里需要避免子节点再次被添加直接 return 返回空就行了，这样子节点不会再次被遍历，到这里就终止了
zhoushaw
approved these changes
Aug 28, 2024
zhoushaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.