fix: fix modifyRoutes in ssr (#4219)

* fix: fix `modifyRoutes` in ssr * chore: changeset
web-infra-dev · Jul 17, 2023 · b591092 · b591092
1 parent 645e111
commit b591092
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.changeset/stupid-zebras-grab.md b/.changeset/stupid-zebras-grab.md
@@ -0,0 +1,6 @@
+---
+'@modern-js/runtime': patch
+---
+
+fix: fix `modifyRoutes` in SSR
+fix: 修复 SSR 时, `modifyRoutes` 执行时机
diff --git a/packages/runtime/plugin-runtime/src/router/runtime/plugin.node.tsx b/packages/runtime/plugin-runtime/src/router/runtime/plugin.node.tsx
@@ -87,7 +87,7 @@ export const routerPlugin = ({
           const _basename =
             baseUrl === '/' ? urlJoin(baseUrl, basename) : baseUrl;
 
-          const routes = createRoutes
+          let routes = createRoutes
             ? createRoutes()
             : createRoutesFromElements(
                 renderRoutes({
@@ -99,6 +99,9 @@ export const routerPlugin = ({
                 }),
               );
 
+          const runner = (api as any).useHookRunners();
+          routes = runner.modifyRoutes(routes);
+
           const { query } = createStaticHandler(routes, {
             basename: _basename,
           });
@@ -119,9 +122,6 @@ export const routerPlugin = ({
           context.routeManifest = context.ssrContext!
             .routeManifest as RouteManifest;
 
-          const runner = (api as any).useHookRunners();
-          runner.modifyRoutes(routes);
-
           return next({ context });
         },
         hoc: ({ App }, next) => {