-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): support custom logger #4522
Conversation
🦋 Changeset detectedLatest commit: b7bbce8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 268 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4522 +/- ##
==========================================
- Coverage 57.59% 51.99% -5.61%
==========================================
Files 672 673 +1
Lines 17794 18440 +646
Branches 3876 4276 +400
==========================================
- Hits 10249 9588 -661
- Misses 6934 8161 +1227
- Partials 611 691 +80 ☔ View full report in Codecov by Sentry. |
Summary
Support custom logger for rspress cli.
🤖 Generated by Copilot at 1e37d9f
This pull request improves the logging and port handling of the dev and prod servers in the
builder-shared
package. It adds a customLogger
interface and asilent
option to thestartDevServer
andstartProdServer
functions. It also updates the types, imports, and changeset files accordingly.Details
🤖 Generated by Copilot at 1e37d9f
logger
andgetPortSilently
parameters tostartDevServer
function to customize dev server behavior and output (link, link, link, link)logger
import todefaultLogger
indevServer.ts
to avoid confusion withlogger
option (link)Logger
interface import andtype
keyword toprodServer.ts
for custom logger object and TypeScript readability (link)printLogger
parameter toprintServerURLs
function to use custom logger object instead of default one (link, link)slient
parameter togetPort
function to suppress port change log message (link, link)Related Issue
Checklist
pnpm run change
.