-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(builder): fix withPublicPath may missing subpath #4535
fix(builder): fix withPublicPath may missing subpath #4535
Conversation
🦋 Changeset detectedLatest commit: ec63460 The changes in this PR will be included in the next version bump. This PR includes changesets to release 268 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4535 +/- ##
==========================================
- Coverage 57.59% 52.37% -5.23%
==========================================
Files 672 670 -2
Lines 17794 18435 +641
Branches 3876 4271 +395
==========================================
- Hits 10249 9655 -594
- Misses 6934 8093 +1159
- Partials 611 687 +76 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at ec63460
This pull request fixes and simplifies the
withPublicPath
function in the@modern-js/builder-shared
package, updates the corresponding test cases, and adds a changeset file for the patch update. This improves the URL handling and documentation of the package.Details
🤖 Generated by Copilot at ec63460
withPublicPath
function inurl.ts
to useurlJoin
function for all cases of joiningbase
andstr
parameters (link,link)withPublicPath
function inurl.test.ts
to match the new function logic and output (link)path
module fromurl.ts
(link)@modern-js/builder-shared
package with patch update and summary of fix in.changeset/few-olives-remain.md
(link)Related Issue
Checklist
pnpm run change
.