Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-preset): should merge targets array correctly #1182

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Should merge targets array correctly.

deepmerge will merge ['node >= 14'] and ['node >= 16'] into ['node >= 14', 'node >= 16'], which is not as expected. So we need to add some conditions.

Checklist

  • Tests updated.
  • Documentation updated.

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit b7b7ce9
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6597b96aa33d48000852bbee
😎 Deploy Preview https://deploy-preview-1182--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan enabled auto-merge (squash) January 5, 2024 08:10
@chenjiahan chenjiahan merged commit 9b77e48 into main Jan 5, 2024
11 checks passed
@chenjiahan chenjiahan deleted the merge_targets_0105 branch January 5, 2024 08:17
@chenjiahan chenjiahan mentioned this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant