feat(plugin-svelte): support pass preprocess options #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Jan 5, 2024
| * | ||
| * See https://github.com/sveltejs/svelte-preprocess | ||
| */ | ||
| preprocessOptions?: AutoPreprocessOptions; |
There was a problem hiding this comment.
Thanks! Can you add an unit test for this new option?
see: packages/plugin-svelte/tests/index.test.ts
There was a problem hiding this comment.
done :)
but the snapshot was not serialized as expected
There was a problem hiding this comment.
haha, maybe we can improve the snapshot in the future
tmkx
force-pushed
the
feat/svelte-preprocess-options
branch
from
3bb913b
to
eb07d3b
Compare
chenjiahan
approved these changes
Jan 5, 2024
|
Thanks! ❤️ Can you submit another PR to update the document? |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Links
Checklist