Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not clean dist path if it is outside root #1433

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

chenjiahan
Copy link
Member

Summary

When output.distPath.root is an external directory, cleanDistPath is not enabled by default, to avoid accidentally deleting files from other directories.

Checklist

  • Tests updated.
  • Documentation updated.

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 8cea4a3
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/65b273b9ede63900081ad7fa
😎 Deploy Preview https://deploy-preview-1433--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit f90c127 into main Jan 25, 2024
9 of 10 checks passed
@chenjiahan chenjiahan deleted the clean_dist_path_0125 branch January 25, 2024 14:44
@chenjiahan chenjiahan mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant