Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to load MF remote modules when using server.base #3790

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Fix failed to load MF remote modules when using server.base.

The default dev.assetPrefix is set to the value of server.base, and Rsbuild should replace it with dev.assetPrefix: true to ensure that the remote module's assets can be requested by consumer apps with the correct URL.

Related Links

resolve #3780

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 706b283
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/671734bbc99d920008e3a115
😎 Deploy Preview https://deploy-preview-3790--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🟢 up 10 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nyqykk nyqykk merged commit 2152285 into main Oct 22, 2024
10 checks passed
@nyqykk nyqykk deleted the mf_with_base_1022 branch October 22, 2024 06:16
@chenjiahan chenjiahan mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Module Federation - Remote app fails to load when running with a base path
2 participants