feat(theme-default): children, outline and fixes for Badge #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for aquamarine-blini-95325f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Huxpro
changed the title
Timeless0911
reviewed
Oct 9, 2024
Timeless0911
reviewed
Oct 9, 2024
Timeless0911
reviewed
Oct 9, 2024
|
Very detailed PR and documentation description, thank you 👍 |
Improve built-in `<Badge>` components: - Custom children: this is particularly useful for adding icons. - `outline` support: more variations! - Style tweak: - use CSS variables from containers to look consistent. - fixes default badge being invisible in Dark mode. - better vertically aligned with different headings. - Changes to `type` props: - add `info` type to be consistent with containers. - `tip` is added as the new default. Do note that even though this kept untyped `<Badge>` unchanged, it does introduce a **benign** breaking change to `<Badge type="info">`. Changes to Docs: - Badges docs are updated to reflect the new usages and new types. - This MR correct "Internal Components" to be "Built-in Components". (does not involve URL changes due to the use of fragments)
Timeless0911
approved these changes
Oct 9, 2024
|
Awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve built-in
<Badge>components:outlinesupport: more variations!typeprops:infotype to be consistent with containers.tipis added as the new default.Do note that even though this kept untyped
<Badge>unchanged, itdoes introduce a benign breaking change to
<Badge type="info">.Before vs. After
Light mode:
Dark mode:
Changes to Docs:
(does not involve URL changes due to the use of fragments)
Related Issue
Dunno.
Checklist