Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support location of overview and search docs #1493

Merged
merged 12 commits into from
Oct 19, 2024

Conversation

Yukiniro
Copy link
Contributor

Summary

Related Issue

Closes #1490

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 7bc93e3
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67130ef8f18252000826b7e6
😎 Deploy Preview https://deploy-preview-1493--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911
Copy link
Collaborator

Timeless0911 commented Oct 17, 2024

Thank you!

image

Can you localize these text too?

@Yukiniro
Copy link
Contributor Author

Yes. I will do it.

@Timeless0911
Copy link
Collaborator

Timeless0911 commented Oct 17, 2024

filter 组件的三个配置文本可以设置为一个对象

overview: {
	filterNameText: string;
	filterPlaceholderText: string;
	filterNoResultText: string;
}

另外,通过在添加一个额外字段 overviewTitleText 去处理不使用 frontmatter.title 不太合理,理想情况应该是可以在 content 的 ReactNode 中剔除多余的 h1 标题,先回到你原来的修改吧。

@Yukiniro
Copy link
Contributor Author

filter 组件的三个配置文本可以设置为一个对象

overview: {
	filterNameText: string;
	filterPlaceholderText: string;
	filterNoResultText: string;
}

另外,通过在添加一个额外字段 overviewTitleText 去处理不使用 frontmatter.title 不太合理,理想情况应该是可以在 content 的 ReactNode 中剔除多余的 h1 标题,先回到你原来的修改吧。

嗯,那我这里就移除 overviewTitleText 的处理,然后将 filter 的相关字段整合到新的 overview 字段中,是这样吗?

@Timeless0911
Copy link
Collaborator

嗯嗯是的

@Timeless0911
Copy link
Collaborator

Can you rebase main branch to resolve some conflicts?

@Yukiniro
Copy link
Contributor Author

ok

Copy link
Collaborator

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Timeless0911 Timeless0911 merged commit 422a9d9 into web-infra-dev:main Oct 19, 2024
7 checks passed
@Yukiniro Yukiniro deleted the ifybhodm branch October 19, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Built-in UIs e.g. Search Docs, Overview are not localized.
2 participants