Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-container-syntax): typical markdown blockquote syntax throwing error #1494

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

ArnavK-09
Copy link
Contributor

@ArnavK-09 ArnavK-09 commented Oct 17, 2024

Summary

resolves #1489

image

Related Issue

#1469

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 1b0c32e
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/671142531b3fe4000813a4c5
😎 Deploy Preview https://deploy-preview-1494--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArnavK-09
Copy link
Contributor Author

ArnavK-09 commented Oct 17, 2024

@Timeless0911 hey can you help me pls ;-;
something wrong with nx or pnpm
I'm so noob in monorepos

@Timeless0911
Copy link
Collaborator

You should run corepack enable in your Rspress project, and automatically use correct version of pnpm

image

Current lockfile should be reset first.

@Timeless0911 Timeless0911 changed the title fix(@rspress/plugin-container-syntax): typical markdown blockquote syntax throwing error + feat: e2e tests fix(plugin-container-syntax): typical markdown blockquote syntax throwing error Oct 17, 2024
@Timeless0911
Copy link
Collaborator

I have reset the lockfile, and you have forgot to write tests in https://github.com/ArnavK-09/rspress/tree/main/e2e/tests.

This PR is able to merge, tests can be added later.

@Timeless0911 Timeless0911 enabled auto-merge (squash) October 17, 2024 17:02
@Timeless0911 Timeless0911 merged commit 2c4940a into web-infra-dev:main Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot read properties of undefined (reading 'toString') when markdown.mdxRs: false
2 participants