Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Card and LinkCard components #1512

Merged
merged 15 commits into from
Oct 22, 2024
Merged

feat: support Card and LinkCard components #1512

merged 15 commits into from
Oct 22, 2024

Conversation

Yukiniro
Copy link
Contributor

Summary

Closes #1506

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 87c5362
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/671725804376c60008d8801a
😎 Deploy Preview https://deploy-preview-1512--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (🟢 up 8 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Timeless0911
Timeless0911 reviewed Oct 21, 2024
View reviewed changes
.changeset/tender-hornets-obey.md Outdated Show resolved Hide resolved
packages/document/docs/en/fragments/builtin-components.mdx Outdated Show resolved Hide resolved
packages/document/docs/en/fragments/builtin-components.mdx Outdated Show resolved Hide resolved
packages/document/docs/zh/fragments/builtin-components.mdx Outdated Show resolved Hide resolved
packages/document/docs/zh/fragments/builtin-components.mdx Outdated Show resolved Hide resolved
packages/theme-default/src/components/Card/index.tsx Show resolved Hide resolved
packages/theme-default/src/components/Card/index.tsx Outdated Show resolved Hide resolved
packages/theme-default/src/components/LinkCard/index.tsx Show resolved Hide resolved
packages/theme-default/src/components/Card/index.tsx Outdated Show resolved Hide resolved
packages/theme-default/src/components/LinkCard/index.tsx Outdated Show resolved Hide resolved
Yukiniro and others added 8 commits October 21, 2024 18:10
@Yukiniro @Timeless0911
Update .changeset/tender-hornets-obey.md
69d81e8 
Co-authored-by: Timeless0911 <[email protected]>
@Yukiniro @Timeless0911
Update packages/document/docs/en/fragments/builtin-components.mdx
e1345c5 
Co-authored-by: Timeless0911 <[email protected]>
@Yukiniro @Timeless0911
Update packages/document/docs/en/fragments/builtin-components.mdx
7f2f2b4 
Co-authored-by: Timeless0911 <[email protected]>
@Yukiniro @Timeless0911
Update packages/document/docs/zh/fragments/builtin-components.mdx
063e88b 
Co-authored-by: Timeless0911 <[email protected]>
@Yukiniro @Timeless0911
Update packages/document/docs/zh/fragments/builtin-components.mdx
eb0d50c 
Co-authored-by: Timeless0911 <[email protected]>
@Yukiniro @Timeless0911
Update packages/theme-default/src/components/Card/index.tsx
4a5634f 
Co-authored-by: Timeless0911 <[email protected]>
@Yukiniro
feat: update the doc, props for Card and LInkCard
2691c49
@Yukiniro
Merge branch 'main' into defhdzcb
fe1727b
Timeless0911
Timeless0911 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks!

@Timeless0911 Timeless0911 enabled auto-merge (squash) October 22, 2024 04:16
@Timeless0911 Timeless0911 merged commit 786acb2 into web-infra-dev:main Oct 22, 2024
7 checks passed
@Yukiniro Yukiniro deleted the defhdzcb branch October 22, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees
No one assigned
Labels
change: feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Hope to provide Card and LinkCard components
2 participants
@Yukiniro @Timeless0911