Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script to re-label Safari 12.1 STP runs #18

Closed
wants to merge 1 commit into from
Closed

Script to re-label Safari 12.1 STP runs #18

wants to merge 1 commit into from

Conversation

stephenmcgruer
Copy link
Contributor

@stephenmcgruer
Copy link
Contributor Author

@Hexcles PTAL. I don't intend to land this, but want it reviewed before I run it. On dry-run, it hits just under 150 runs.

foolip
foolip reviewed Jan 2, 2020
View reviewed changes
tagger/safari_12_1_stp.go
return false
}
// We ran Safari 12.1 as STP from 2018-08-07 until 2019-01-05. It then
// released as stable 2019-04-09. So anything after February (to pick
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the earliest run after this cutoff point?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a bit of misleading wording.

Safari 12.1 was released on 2019/03/25 (https://en.wikipedia.org/wiki/Safari_version_history#Safari_12). The first stable WPT run (aka the earliest run) was 2019/04/09.

@stephenmcgruer
Copy link
Contributor Author

Script has been run on staging + prod. Logs attached:

stp_12_1_log.txt
stp_12_1_log_staging.txt

@stephenmcgruer stephenmcgruer deleted the smcgruer/switch-safari-12.1-runs branch January 2, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@Hexcles Hexcles Awaiting requested review from Hexcles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenmcgruer @foolip