Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Py2 support #121

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Conversation

AutomatedTester
Copy link
Contributor

This is based on top of #119.

@jeffcarp
Copy link
Contributor

Thanks for this. Looks like it needs a rebase but otherwise in general lgtm.

@gsnedders
Copy link
Member

I'd personally prefer we kept Python 3 support, given it seems not inconceivable we'll move over to Python 3 at some point in the future.

@AutomatedTester
Copy link
Contributor Author

@gsnedders I agree that it would have been nice but ideally we need to make sure that our runners are moved to py3, or at least py2 and py3 support, before doing this.

The current setup for wptdashboard is having both py2 and py3 setup in the same project which seems suboptimal at best.

This aligns with all the other python code that W3C and browser vendors
use in their infrastructure.
@AutomatedTester
Copy link
Contributor Author

rebased.

@jeffcarp
Copy link
Contributor

Let's take a step back, @AutomatedTester what is your use case for running run/run.py? The machines it's intended for, the WPTD VMs, have no problem installing both pythons.

@jgraham
Copy link
Collaborator

jgraham commented Sep 22, 2017

The use case is being able to run things locally with the exact same settings as CI in order to debug problems. In this case I think that @AutomatedTester is specifically interested in the tests in webdriver/.

@AutomatedTester
Copy link
Contributor Author

@jeffcarp This is because setting up this locally has proven to be near on impossible. Following good practises for python, like using a virtualenv, means using 2 version of python unnecessarily hard.

I am trying to fix #90 but I haven't even been able to run the tests yet. I have other setup patches locally to be able to make sure the necessary dependencies are there. Some of the dependencies only run on Python2.7.

@bobholt
Copy link
Contributor

bobholt commented Sep 25, 2017

👍 Running locally should be both possible and easy to do in a virtualenv.

@bobholt bobholt merged commit 51c47a7 into web-platform-tests:master Sep 25, 2017
This was referenced Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants