This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Add support for filtering change types when diffing #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebjerring
commented
Nov 27, 2017
| diff[test] = []int{ | ||
| max(passDiff, countDiff), | ||
| max(resultsBefore[1], resultsAfter[1]), | ||
| if filter.Deleted || filter.Changed { |
There was a problem hiding this comment.
This diff tool isn't great. FWIW, changes are just:
- Surround whole code-block in the if-statement above
- Add continue if-statements
foolip
approved these changes
Nov 29, 2017
| param = DiffFilterParam{} | ||
| for _, char := range filter { | ||
| switch char { | ||
| case 'A': |
There was a problem hiding this comment.
Comment around here as well that this is inspired by git --diff-filter=, which, BTW, I really like :) I don't think that rename detection is in any way a straightforward thing, or likely to ever be worth doing, but if we do, it should be 'R'.
There was a problem hiding this comment.
Noted, and Done.
| diff[test] = []int{ | ||
| max(passDiff, countDiff), | ||
| max(resultsBefore[1], resultsAfter[1]), | ||
| if filter.Deleted || filter.Changed { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #301
Uses a git-inspired filtering charset param.
?filter=[A][C][D]
A = Added
C = Changed
D = Deleted