-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 72: Address space overrides. #72
Conversation
To keep this RFC up-to-date, at this point I believe WPT's stance* is that this should be done via browser flags rather than have the testrunner (or some setup done by the testrunner) have system privileges. Both Blink and Gecko infra have said that having privileges in this way is at least not commonly done (but not explicitly banned). We would like to see the aforementioned issues against browsers opened and discussions occur there (please link to them in this discussion). If a reasonable number of browsers think the level of support is unacceptably high, we can revisit the system-privilege angle. * Based on discussion between @jgraham and myself today, plus previous comments from @Hexcles |
I will open issues against other browsers to seek their input. Thanks for the discussion so far! |
Filed bug 1681316 against Firefox. Any help locating appropriate contacts within Mozilla to assign the bug to or cc on the bug is appreciated! |
Filed bug 219642 against WebKit. |
Thanks @jgraham for helping triage the Firefox bug. Does anyone on this thread have a contact at WebKit I could ask to get some traction on that bug? |
@gsnedders perhaps |
Thanks! |
Addresses issue web-platform-tests/wpt#26166.
@stephenmcgruer I believe we have consent from Gecko (see @ddragana's comment above) and WebKit (see bug 219642). OK with you to proceed? |
Unfortunately I'm no longer working on WPT matters, so I don't want to say yes when the consequences are on others. Instead, passing this to foolip@ and jgraham@ to sign off. For the record, I think this should be good to go based on #72 (comment) and the subsequent work letitz has done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't followed the discussion leading up to this, but reading through the whole proposal it makes good sense to me. It seems like a good trade off among the alternatives considered.
Thanks for the reviews! I'm not familiar with this workflow: how does this PR get merged now? |
As a newly returning member of the wpt core team there's a risk of embarrassing myself here, but per https://github.com/web-platform-tests/rfcs#the-rfc-process the latest "new information" would be your ping in #72 (comment) and we can consider this accepted if there's no further feedback by March 31. |
Oh, I believed the previous discussion and your approvals were enough. It seems to me all stakeholders have had ample time to review this since November. Anyway, I won't haggle for 2 days after 5 months of waiting. Glad this is finally getting merged :) |
@letitz I'm only unsure about the status of WebKit and wanted to be sure @gsnedders had the full 7 days after this became ready to go. https://bugs.webkit.org/show_bug.cgi?id=219642 doesn't load for me right now, but if the discussion has already happened there, then really we could go ahead. Please feel free to prepare an implementation PR in the meantime. |
Alright, two more days have passed, I'm merging this now. |
Addresses issue web-platform-tests/wpt#26166.
cc @mikewest @camillelamy @hemeryar