Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple results per product when more than 1 sha #1035

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Conversation

lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Jan 16, 2019

Description

Changes the behaviour of querying for multiple shas, to not implicitly set a max-count of one result for each product. (For other queries, such as no params, the default is one result per product).

If a user wants exactly one result per product (across 2 shas) they can add the param explicitly.

@wpt-pr-bot
Copy link

Staging instance deployed by Travis CI!
Running at https://shas-dot-wptdashboard-staging.appspot.com

@lukebjerring
Copy link
Contributor Author

@Hexcles
Copy link
Member

Hexcles commented Jan 16, 2019

Change the behaviour of querying for multiple shas without to not implicitly set a max-count of one result for each product.

I'm having trouble parsing this sentence. Besides, could you explain the motive a bit more?

@lukebjerring
Copy link
Contributor Author

Sorry, I typed many word do the explain. Revised to be interpretable as English.

We added support for multiple SHA params as part of the ?pr=123 support, but it behaves strangely. this pr makes it behaves more as you might expect (if you ask for more than one Sha, you get all results across those shas)

Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. LGTM!

@Hexcles
Copy link
Member

Hexcles commented Jan 17, 2019

If there's existing tests related to the default value of limit, I'd like you to make them cover the new condition. Otherwise, it's perhaps not that important.

@lukebjerring
Copy link
Contributor Author

Currently untested - tests would need a refactor. Separate PR.

@lukebjerring lukebjerring merged commit d8cafb3 into master Jan 17, 2019
@lukebjerring lukebjerring deleted the shas branch January 17, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants