Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is:tentative command #1611

Merged
merged 4 commits into from
Nov 7, 2019
Merged

Add is:tentative command #1611

merged 4 commits into from
Nov 7, 2019

Conversation

stephenmcgruer
Copy link
Contributor

Fixes #36

Hexcles
Hexcles approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a nit

api/query/atoms.go Outdated Show resolved Hide resolved
@stephenmcgruer
Copy link
Contributor Author

Ahaha, appreciate the fast review but this was meant to be a draft (whoops). Will re-ping when ready for review.

@stephenmcgruer stephenmcgruer mentioned this pull request Nov 5, 2019
Closed
@foolip
Copy link
Member

foolip commented Nov 6, 2019

How about doing is:optional as well? :)

@stephenmcgruer
Copy link
Contributor Author

Ok PTAL @Hexcles (low priority). It has tests now! :D

Hexcles
Hexcles approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again. Thanks for adding tests!

@Hexcles Hexcles merged commit 1068a6b into master Nov 7, 2019
@Hexcles Hexcles deleted the smcgruer/tentative branch November 7, 2019 23:13
machogallo
machogallo reviewed Nov 8, 2019
View reviewed changes
Copy link

@machogallo machogallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machogallo machogallo machogallo left review comments

@Hexcles Hexcles Hexcles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Disregard or elsehow mark tentative tests.
5 participants
@stephenmcgruer @foolip @Hexcles @machogallo @wpt-pr-bot