Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the URL when submitting a query #608

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

lukebjerring
Copy link
Contributor

Description

One step further for #535

Updates the url when a query is submitted.

Review Information

  • Visit /flags, enable query builder
  • Visit /results, build a query, submit
  • See that the query params have updated.

@wpt-pr-bot
Copy link

Staging instance deployed by Travis CI!
Running at https://query-builder-5-dot-wptdashboard-staging.appspot.com

@lukebjerring lukebjerring changed the base branch from master to query-builder-4 October 2, 2018 13:15
@foolip
Copy link
Member

foolip commented Oct 2, 2018

I had some fun playing with the query builder. There's one thing I couldn't get to work, which does work on staging.wpt.fyi: add Chrome stable and Chrome beta with or without "Align runs" checked. The resulting URL is https://query-builder-5-dot-wptdashboard-staging.appspot.com/results/?product=chrome&product=chrome, i.e., the channel isn't part of the URL. The result is that only one column is shown.

@lukebjerring lukebjerring merged commit f240a24 into query-builder-4 Oct 2, 2018
@lukebjerring
Copy link
Contributor Author

Merging this into query-builder-5 to resolve the issues seen there. One PR to rule them all.

@Hexcles Hexcles deleted the query-builder-5 branch October 5, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants