Add icons to the query builder dropdowns #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Staging instance deployed by Travis CI! |
|
Ooooh, this is beautiful! I would, however, like to reiterate the request in #685 (comment), to gray out impossible combinations, since it's made a little bit more obvious here. There is no such thing as Safari Dev, and yet we're showing a purple icon for it. Similarly for Firefox Dev (Developer Edition) which does exist, but has a different icon. |
foolip
approved these changes
Oct 29, 2018
added 2 commits
October 30, 2018 09:17
|
Staging instance deployed by Travis CI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More #535 work.
Cosmetic change to include the product icons in the dropdowns.
Review Information
Toggle the
ProductandChanneldropdowns, see icons.