Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run deploy on forks #83

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

lukebjerring
Copy link
Contributor

Forks can't access Travis CI secrets (by design), so the creds needed for a staging deploy are not available. Bypass the task.

Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this now. After you merge it, could you rebase your #82 and trigger Travis again to verify? Thanks!

.travis.yml Outdated
@@ -91,7 +91,7 @@ install:

script:
- | # Deploy PR to staging environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: a comment would be great. (e.g. "... only when Travis secrets are available")

@lukebjerring
Copy link
Contributor Author

Looks like the breakages might be unrelated, potentially caused by
golang/lint@c363707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants