Skip to content

Commit

Permalink
Only create one video element in these test-cases.
Browse files Browse the repository at this point in the history
Also update ini file for rtp-demuxing test to point at the cause of the timeout.

Differential Revision: https://phabricator.services.mozilla.com/D171930

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1818127
gecko-commit: 6016316186ae17131349336dd732138a8336ab49
gecko-reviewers: pehrsons
  • Loading branch information
docfaraday authored and pull[bot] committed Jul 10, 2023
1 parent dddf2da commit 1045668
Showing 1 changed file with 20 additions and 28 deletions.
48 changes: 20 additions & 28 deletions webrtc/protocol/bundle.https.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,31 +17,28 @@
t.add_cleanup(() => stream.getTracks().forEach(track => track.stop()));
stream.getTracks().forEach(track => caller.addTrack(track, stream));

let metadataToBeLoaded;
callee.ontrack = (e) => {
const stream = e.streams[0];
const v = document.createElement('video');
v.autoplay = true;
v.srcObject = stream;
v.id = stream.id
metadataToBeLoaded = new Promise((resolve) => {
v.addEventListener('loadedmetadata', () => {
resolve();
});
});
};

exchangeIceCandidates(caller, callee);
const offer = await caller.createOffer();
// remove the a=group:BUNDLE from the SDP when signaling.
const sdp = offer.sdp.replace(/a=group:BUNDLE (.*)\r\n/, '');
const ontrack = new Promise(r => callee.ontrack = r);

await callee.setRemoteDescription({type: 'offer', sdp});
await caller.setLocalDescription(offer);

const answer = await callee.createAnswer();
await caller.setRemoteDescription(answer);
await callee.setLocalDescription(answer);

await metadataToBeLoaded;
const {streams: [recvStream]} = await ontrack;
assert_equals(recvStream.getTracks().length, 2, "Tracks should be added to the stream before sRD resolves.");
const v = document.createElement('video');
v.autoplay = true;
v.srcObject = recvStream;
v.id = recvStream.id;
await new Promise(r => v.onloadedmetadata = r);

const senders = caller.getSenders();
const dtlsTransports = senders.map(s => s.transport);
assert_equals(dtlsTransports.length, 2);
Expand All @@ -61,21 +58,9 @@
t.add_cleanup(() => stream.getTracks().forEach(track => track.stop()));
stream.getTracks().forEach(track => caller.addTrack(track, stream));

let metadataToBeLoaded;
callee.ontrack = (e) => {
const stream = e.streams[0];
const v = document.createElement('video');
v.autoplay = true;
v.srcObject = stream;
v.id = stream.id
metadataToBeLoaded = new Promise((resolve) => {
v.addEventListener('loadedmetadata', () => {
resolve();
});
});
};
exchangeIceCandidates(caller, callee);
const offer = await caller.createOffer();
const ontrack = new Promise(r => callee.ontrack = r);
await callee.setRemoteDescription(offer);
await caller.setLocalDescription(offer);
const secondTransport = caller.getSenders()[1].transport; // Save a reference to this transport.
Expand All @@ -84,7 +69,14 @@
await caller.setRemoteDescription(answer);
await callee.setLocalDescription(answer);

await metadataToBeLoaded;
const {streams: [recvStream]} = await ontrack;
assert_equals(recvStream.getTracks().length, 2, "Tracks should be added to the stream before sRD resolves.");
const v = document.createElement('video');
v.autoplay = true;
v.srcObject = recvStream;
v.id = recvStream.id;
await new Promise(r => v.onloadedmetadata = r);

const senders = caller.getSenders();
const dtlsTransports = senders.map(s => s.transport);
assert_equals(dtlsTransports.length, 2);
Expand Down

0 comments on commit 1045668

Please sign in to comment.