Skip to content

Commit

Permalink
Changing OOF type may affect the need for column sets.
Browse files Browse the repository at this point in the history
Changing from fixed to absolute position may require us to insert a
column set. Failing to do this may cause immediate rendering problems,
but can also lead to crashes further down the road, because we assume
that there's a column set for the object.

Be less restrictive about (re-)inserting objects into the flow thread.

Bug: 1074480
Change-Id: I8da6a09841d4a857752ebfd9668d669635c0a9bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173059
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#763852}
  • Loading branch information
mstensho authored and chromium-wpt-export-bot committed Apr 29, 2020
1 parent 421a236 commit 31da90b
Showing 1 changed file with 15 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1074480">
<p>PASS if no crash.</p>
<body style="columns:2;">
<div style="position:relative;">
<div style="column-span:all;"></div>
<div id="target" style="columns:2; position:fixed;"></div>
</div>
</body>
<script>
document.body.offsetTop;
target.style.position = 'absolute';
target.style.columns = 'auto';
</script>

0 comments on commit 31da90b

Please sign in to comment.