Skip to content

Commit

Permalink
Move from offerToReceiveAudio to addTransceiver('audio')
Browse files Browse the repository at this point in the history
  • Loading branch information
youennf committed Nov 4, 2018
1 parent 6d93a8a commit 59e5213
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
10 changes: 10 additions & 0 deletions webrtc/RTCPeerConnection-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,16 @@ function generateOffer(options={}) {
});
}

async function generateAudioReceiveOnlyOffer(pc)
{
try {
pc.addTransceiver('audio', { direction: 'recvonly' });
return pc.createOffer();
} catch(e) {
return pc.createOffer({ offerToReceiveAudio: true });
}
}

async function generateVideoReceiveOnlyOffer(pc)
{
try {
Expand Down
8 changes: 4 additions & 4 deletions webrtc/RTCPeerConnection-setRemoteDescription.html
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
assert_equals(state, states[eventCount]);
};

const offer = await pc.createOffer({ offerToReceiveAudio: true });
const offer = await generateAudioReceiveOnlyOffer(pc);
assert_state('stable');
await pc.setLocalDescription(offer);
assert_state('have-local-offer');
Expand All @@ -111,10 +111,10 @@
t.add_cleanup(() => pc.close());
t.add_cleanup(() => pc2.close());

const offer1 = await pc2.createOffer({ offerToReceiveAudio: true });
const offer1 = await generateAudioReceiveOnlyOffer(pc2);
await pc.setRemoteDescription(offer1);
await pc.setLocalDescription(await pc.createAnswer());
const offer2 = await pc2.createOffer({ offerToReceiveVideo: true });
const offer2 = await generateVideoReceiveOnlyOffer(pc2);
await pc.setRemoteDescription(offer2);
assert_session_desc_not_similar(offer1, offer2);
assert_session_desc_similar(pc.remoteDescription, offer2);
Expand All @@ -128,7 +128,7 @@
t.add_cleanup(() => pc.close());
t.add_cleanup(() => pc2.close());

const offer = await pc.createOffer({ offerToReceiveAudio: true });
const offer = await generateAudioReceiveOnlyOffer(pc);
await pc.setLocalDescription(offer);
await pc2.setRemoteDescription(offer);
const answer = await pc2.createAnswer();
Expand Down

0 comments on commit 59e5213

Please sign in to comment.